[ 
https://issues.apache.org/jira/browse/TINKERPOP-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539157#comment-17539157
 ] 

ASF GitHub Bot commented on TINKERPOP-2745:
-------------------------------------------

li-boxuan commented on PR #1659:
URL: https://github.com/apache/tinkerpop/pull/1659#issuecomment-1130943291

   > Would you mind taking a look at these and see if there is a way to add 
tests somehow
   
   TinkerGraph itself is schemaless so I cannot think of a way to test the new 
getter methods. It is possible to add a new graph provider in the test package 
which enforces some sort of schema so that these new getter methods can be 
tested. That being said, I am not sure if that is worth it and if that is the 
best practice. Maybe @spmallette has some insights here?




> Add getter for vertex properties in vertex programs
> ---------------------------------------------------
>
>                 Key: TINKERPOP-2745
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2745
>             Project: TinkerPop
>          Issue Type: Improvement
>            Reporter: Boxuan Li
>            Priority: Major
>
> Many if not all vertex programs will mutate vertex properties during the 
> computation process. For graphs that enforce a schema, this could lead to 
> failure. JanusGraph, for example, when used with FulgoraGraphComputer and 
> disabled automatic schema maker, will report error for vertex programs. See 
> [https://gitter.im/janusgraph/janusgraph?at=626c568910cfc315bc5781a0]
>  
> This ticket proposes a getter method for each vertex program, which would 
> return the vertex properties together with their data types needed in the 
> computation. The graph providers or users could then leverage this 
> information to create the corresponding schema.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to