[
https://issues.apache.org/jira/browse/TINKERPOP-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539461#comment-17539461
]
ASF GitHub Bot commented on TINKERPOP-2745:
-------------------------------------------
spmallette commented on code in PR #1659:
URL: https://github.com/apache/tinkerpop/pull/1659#discussion_r876910116
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/connected/ConnectedComponentVertexProgram.java:
##########
@@ -76,6 +75,14 @@ public class ConnectedComponentVertexProgram implements
VertexProgram<String> {
private ConnectedComponentVertexProgram() {}
+ @Override
+ public List<Pair<String, Class>> getVertexPropertyKeys() {
+ return Arrays.asList(
+ org.apache.commons.lang3.tuple.Pair.of(HALTED_TRAVERSERS,
Object.class),
Review Comment:
Please prefer `org.javatuples.Pair` as that is used throughout the project.
> Add getter for vertex properties in vertex programs
> ---------------------------------------------------
>
> Key: TINKERPOP-2745
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2745
> Project: TinkerPop
> Issue Type: Improvement
> Reporter: Boxuan Li
> Priority: Major
>
> Many if not all vertex programs will mutate vertex properties during the
> computation process. For graphs that enforce a schema, this could lead to
> failure. JanusGraph, for example, when used with FulgoraGraphComputer and
> disabled automatic schema maker, will report error for vertex programs. See
> [https://gitter.im/janusgraph/janusgraph?at=626c568910cfc315bc5781a0]
>
> This ticket proposes a getter method for each vertex program, which would
> return the vertex properties together with their data types needed in the
> computation. The graph providers or users could then leverage this
> information to create the corresponding schema.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
