[
https://issues.apache.org/jira/browse/TINKERPOP-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656232#comment-17656232
]
ASF GitHub Bot commented on TINKERPOP-2838:
-------------------------------------------
Cole-Greer commented on code in PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#discussion_r1064943944
##########
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientBehaviorIntegrationTests.cs:
##########
@@ -84,5 +84,37 @@ await
gremlinClient.SubmitWithSingleResultAsync<Vertex>(RequestMessage.Build("1"
Assert.NotNull(response2);
Assert.Equal(1, gremlinClient.NrConnections);
}
+
+ [Fact]
+ public async Task ShouldIncludeUserAgentInHandshakeRequest()
+ {
+ var sessionId = Guid.NewGuid().ToString();
+ var poolSettings = new ConnectionPoolSettings {PoolSize = 1};
+
+ var gremlinServer = new GremlinServer(TestHost, Settings.Port);
+ var gremlinClient = new GremlinClient(gremlinServer,
messageSerializer: Serializer,
Review Comment:
Sure, I will add this
> Add UserAgent GLV Tests
> -----------------------
>
> Key: TINKERPOP-2838
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2838
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.5.4
> Reporter: Cole Greer
> Priority: Minor
>
> User agents were added to all GLV connection requests with
> [TINKERPOP-2480|https://issues.apache.org/jira/browse/TINKERPOP-2480]. The
> Java driver has tests added which utilize SimpleSocketServer to capture and
> echo back the user agent.
> [TINKERPOP-2819|https://issues.apache.org/jira/browse/TINKERPOP-2819] will
> bring SimpleSocketServer to all GLV's. Once this is complete additional tests
> mirroring the Java driver tests should be added to all GLV's to ensure the
> user agent is being sent and received correctly, and that the
> enableUserAgentOnConnect configuration is working correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
