[
https://issues.apache.org/jira/browse/TINKERPOP-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656235#comment-17656235
]
ASF GitHub Bot commented on TINKERPOP-2838:
-------------------------------------------
Cole-Greer commented on code in PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#discussion_r1064947226
##########
gremlin-dotnet/src/Gremlin.Net/Process/Utils.cs:
##########
@@ -32,8 +32,11 @@ namespace Gremlin.Net.Process
/// <summary>
/// Contains useful methods that can be reused across the project.
/// </summary>
- internal static class Utils
+ public static class Utils
Review Comment:
Thanks for suggestions Florian. I have implemented this one using the same
key file as is being used for `Gremlin.Net.UnitTest`. Please let me know if I
should instead be generating new keys for this.
> Add UserAgent GLV Tests
> -----------------------
>
> Key: TINKERPOP-2838
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2838
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.5.4
> Reporter: Cole Greer
> Priority: Minor
>
> User agents were added to all GLV connection requests with
> [TINKERPOP-2480|https://issues.apache.org/jira/browse/TINKERPOP-2480]. The
> Java driver has tests added which utilize SimpleSocketServer to capture and
> echo back the user agent.
> [TINKERPOP-2819|https://issues.apache.org/jira/browse/TINKERPOP-2819] will
> bring SimpleSocketServer to all GLV's. Once this is complete additional tests
> mirroring the Java driver tests should be added to all GLV's to ensure the
> user agent is being sent and received correctly, and that the
> enableUserAgentOnConnect configuration is working correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
