[
https://issues.apache.org/jira/browse/TINKERPOP-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700871#comment-17700871
]
ASF GitHub Bot commented on TINKERPOP-2373:
-------------------------------------------
kenhuuu commented on code in PR #1986:
URL: https://github.com/apache/tinkerpop/pull/1986#discussion_r1137812418
##########
gremlin-console/src/main/static/NOTICE:
##########
@@ -18,15 +18,10 @@ Original source copyright:
Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
------------------------------------------------------------------------
-Apache Groovy 2.5.15 (AL ASF)
+Apache Groovy 4.0.9 (AL ASF)
------------------------------------------------------------------------
-This product includes/uses ANTLR (http://www.antlr2.org/)
-developed by Terence Parr 1989-2006
-
-This product bundles icons from the famfamfam.com silk icons set
-http://www.famfamfam.com/lab/icons/silk/
Review Comment:
> Was this piece intended to be removed? Are the icons no longer bundled?
The NOTICE file doesn't exist anymore in the groovy-console 4.0.9 jar,
however, it does exist in
https://github.com/apache/groovy/blob/GROOVY_4_0_9/subprojects/groovy-console/NOTICE
so maybe we should add it back? In any case, groovy-console is only included
with gremlin-server and not gremlin-console.
> Bump to Groovy 3.0
> ------------------
>
> Key: TINKERPOP-2373
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2373
> Project: TinkerPop
> Issue Type: Improvement
> Components: groovy
> Affects Versions: 3.5.0
> Reporter: Stephen Mallette
> Priority: Major
>
> Groovy 3.0 has been out for a while now and has done several patch releases.
> Time to upgrade on 3.5.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
