[
https://issues.apache.org/jira/browse/TINKERPOP-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701146#comment-17701146
]
ASF GitHub Bot commented on TINKERPOP-2373:
-------------------------------------------
spmallette commented on code in PR #1986:
URL: https://github.com/apache/tinkerpop/pull/1986#discussion_r1138582301
##########
gremlin-console/src/main/static/NOTICE:
##########
@@ -18,15 +18,10 @@ Original source copyright:
Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
------------------------------------------------------------------------
-Apache Groovy 2.5.15 (AL ASF)
+Apache Groovy 4.0.9 (AL ASF)
------------------------------------------------------------------------
-This product includes/uses ANTLR (http://www.antlr2.org/)
-developed by Terence Parr 1989-2006
-
-This product bundles icons from the famfamfam.com silk icons set
-http://www.famfamfam.com/lab/icons/silk/
Review Comment:
my understanding is that for binary distributions, if the packaged jars do
not have the NOTICE included then we do not need it in our NOTICE. if you've
gone through all the groovy jars in both server/console and have only included
what's there then i think we're good.
the groovy NOTICE files we're looking at in code may be all source
NOTICE-related which has a different set of rules to adhere to. we dont package
groovy source so i think we're ok there.
> Bump to Groovy 3.0
> ------------------
>
> Key: TINKERPOP-2373
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2373
> Project: TinkerPop
> Issue Type: Improvement
> Components: groovy
> Affects Versions: 3.5.0
> Reporter: Stephen Mallette
> Priority: Major
>
> Groovy 3.0 has been out for a while now and has done several patch releases.
> Time to upgrade on 3.5.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
