[
https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706613#comment-17706613
]
ASF GitHub Bot commented on TINKERPOP-2852:
-------------------------------------------
Cole-Greer opened a new pull request, #2007:
URL: https://github.com/apache/tinkerpop/pull/2007
Replaces spotify plugin with io.fabric8 docker-maven-plugin. The new plugin
has the benefit of supporting multi-arch images through buildx for deployments
and it is an actively maintained plugin as opposed to the spotify plugin.
The new plugin continues to fetch auth credentials from the same location so
no changes to the release environment will be necessary.
I have tested the full set of .Net gherkin and integration tests against the
new image with no issues. I have also used
[container-diff](https://github.com/GoogleContainerTools/container-diff) to
compare the new image to the one that we currently build using the mvn exec
plugin and docker compose. These are the results:
```
-----File-----
These entries have been added to colegreer/tinkerpop:server-3.5.6-SNAPSHOT:
None
These entries have been deleted from
colegreer/tinkerpop:server-3.5.6-SNAPSHOT: None
These entries have been changed between
colegreer/tinkerpop:server-3.5.6-SNAPSHOT and
tinkerpop/gremlin-server:3.5.6-SNAPSHOT:
FILE SIZE1
SIZE2
/opt/gremlin-server/lib/gremlin-server-3.5.6-SNAPSHOT.jar 243K
242.8K
/etc/ssl/certs/java/cacerts 155.3K
155.3K
-----Apt-----
Packages found only in colegreer/tinkerpop:server-3.5.6-SNAPSHOT: None
Packages found only in tinkerpop/gremlin-server:3.5.6-SNAPSHOT: None
Version differences: None
```
I haven't yet identified the minute difference in the jar file between the
two images. I can investigate this further if anyone views it as a potential
concern.
TODO:
Switch gremlin-console to new plugin.
Support manual image deployment as similar to what `mvn dockerfile:push`
currently does.
> Update Maven plugin for docker-images building for M1 compatibility
> -------------------------------------------------------------------
>
> Key: TINKERPOP-2852
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2852
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.5.4
> Reporter: Yang Xia
> Priority: Critical
>
> The current Maven plug in we use for the `docker-image` building profile is
> no longer maintained
> ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).],
> and it is also not compatible with M1 Macs.
> We should consider swapping the plug in for an actively maintained one that
> is M1 compatible, for example
> [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
