[
https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714753#comment-17714753
]
ASF GitHub Bot commented on TINKERPOP-2852:
-------------------------------------------
Cole-Greer commented on PR #2007:
URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1516940988
@FlorianHockmann Looks like I accidentally removed too much when I attempted
to remove the `latest` tag from 3.5 which was the cause of that error you
observed. I have fixed that and run several tests deploying images with
different versions to a personal dockerhub repo. You can see all of the tags
here
(https://hub.docker.com/repository/docker/colegreer/gremlin-console/tags?page=1&ordering=last_updated,
https://hub.docker.com/repository/docker/colegreer/gremlin-server/tags?page=1&ordering=last_updated).
I tested deployments of `3.5.6-SNAPSHOT`, `3.5.7`, `3.6.3-SNAPSHOT`, and
`3.6.4` to ensure we are getting the correct tags for all of them.
When running these tests I temporarily moved the `docker:push` execution
from the `deploy` phase to the `install` phase as I wanted to test docker
deployment without triggering any of the other deploy phase goals. It's also
noteworthy that the new plugin does not attempt to build the full multi-arch
image during the build goal. The reasoning for this being that multi-arch
images are much larger in size and slow to build. The full multi-arch image is
not built until the `push` goal is executed. This isn't ideal for us but there
doesn't appear to be a good workaround with this plugin. Ultimately I don't
think it is a big issue though, as we only need the multi-arch images during
deployment.
> Update Maven plugin for docker-images building for M1 compatibility
> -------------------------------------------------------------------
>
> Key: TINKERPOP-2852
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2852
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.5.4
> Reporter: Yang Xia
> Priority: Critical
>
> The current Maven plug in we use for the `docker-image` building profile is
> no longer maintained
> ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).],
> and it is also not compatible with M1 Macs.
> We should consider swapping the plug in for an actively maintained one that
> is M1 compatible, for example
> [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
