[
https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715201#comment-17715201
]
ASF GitHub Bot commented on TINKERPOP-2852:
-------------------------------------------
lyndonbauto commented on code in PR #2007:
URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1174226183
##########
gremlin-server/pom.xml:
##########
@@ -378,60 +412,28 @@ limitations under the License.
</configuration>
</plugin>
<plugin>
- <groupId>com.spotify</groupId>
- <artifactId>dockerfile-maven-plugin</artifactId>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
<executions>
<execution>
- <id>docker-image-build</id>
+ <id>docker:build</id>
<goals>
<goal>build</goal>
</goals>
- <configuration>
- <tag>${project.version}</tag>
- <buildArgs>
-
<GREMLIN_SERVER_DIR>target/apache-tinkerpop-${project.artifactId}-${project.version}-standalone</GREMLIN_SERVER_DIR>
- </buildArgs>
- </configuration>
- </execution>
- <execution>
- <id>docker-image-tag-minor-version</id>
- <goals>
- <goal>tag</goal>
- </goals>
- <configuration>
-
<tag>${parsedVersion.majorVersion}.${parsedVersion.minorVersion}</tag>
-
<skip>${only.when.is.prerelease.version}</skip>
- </configuration>
+ <phase>package</phase>
</execution>
<execution>
- <id>docker-image-push</id>
- <phase>deploy</phase>
+ <id>docker:push</id>
<goals>
<goal>push</goal>
</goals>
- <configuration>
- <tag>${project.version}</tag>
- <skip>${only.when.is.snapshot.used}</skip>
- </configuration>
- </execution>
- <execution>
- <id>docker-image-push-minor-version</id>
<phase>deploy</phase>
- <goals>
- <goal>push</goal>
- </goals>
- <configuration>
-
<tag>${parsedVersion.majorVersion}.${parsedVersion.minorVersion}</tag>
-
<skip>${only.when.is.prerelease.version}</skip>
- </configuration>
</execution>
</executions>
- <configuration>
- <repository>tinkerpop/gremlin-server</repository>
- </configuration>
</plugin>
</plugins>
</build>
</profile>
+
Review Comment:
```suggestion
```
> Update Maven plugin for docker-images building for M1 compatibility
> -------------------------------------------------------------------
>
> Key: TINKERPOP-2852
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2852
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.5.4
> Reporter: Yang Xia
> Priority: Critical
>
> The current Maven plug in we use for the `docker-image` building profile is
> no longer maintained
> ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).],
> and it is also not compatible with M1 Macs.
> We should consider swapping the plug in for an actively maintained one that
> is M1 compatible, for example
> [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
