[ 
https://issues.apache.org/jira/browse/TINKERPOP-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719155#comment-17719155
 ] 

ASF GitHub Bot commented on TINKERPOP-2941:
-------------------------------------------

codecov-commenter commented on PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#issuecomment-1534112691

   ## 
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2053?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#2053](https://app.codecov.io/gh/apache/tinkerpop/pull/2053?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (301095f) into 
[3.5-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/3a9ca15e43b1b215f59a9f4c35a34e2a8caab6f2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (3a9ca15) will **decrease** coverage by `5.18%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             3.5-dev    #2053      +/-   ##
   =============================================
   - Coverage      69.42%   64.24%   -5.18%     
   =============================================
     Files            866       25     -841     
     Lines          41251     3759   -37492     
     Branches        5442        0    -5442     
   =============================================
   - Hits           28637     2415   -26222     
   + Misses         10708     1166    -9542     
   + Partials        1906      178    -1728     
   ```
   
   
   [see 841 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2053/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   




> DO NOT purge the output location if it has content in SparkGraphComputer
> ------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2941
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2941
>             Project: TinkerPop
>          Issue Type: Improvement
>    Affects Versions: 3.6.2
>            Reporter: Redriver
>            Priority: Major
>
> The default logic for SparkGraphComputer is to purge all content if the 
> output location is specified. That is a dangerous operation especially for 
> the output location which contains contents.
> https://github.com/apache/tinkerpop/blob/master/spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/process/computer/SparkGraphComputer.java#L317:L324
> The correct behavior is to stop the process if it detects the output location 
> is not empty.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to