[ 
https://issues.apache.org/jira/browse/TINKERPOP-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724399#comment-17724399
 ] 

ASF GitHub Bot commented on TINKERPOP-2941:
-------------------------------------------

kenhuuu commented on PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#issuecomment-1555194730

   Could you please also add a CHANGELOG entry?
   
   VOTE +1, pending minor fixes.




> DO NOT purge the output location if it has content in SparkGraphComputer
> ------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2941
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2941
>             Project: TinkerPop
>          Issue Type: Improvement
>    Affects Versions: 3.6.2
>            Reporter: Redriver
>            Priority: Major
>
> The default logic for SparkGraphComputer is to purge all content if the 
> output location is specified. That is a dangerous operation especially for 
> the output location which contains contents.
> https://github.com/apache/tinkerpop/blob/master/spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/process/computer/SparkGraphComputer.java#L317:L324
> The correct behavior is to stop the process if it detects the output location 
> is not empty.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to