[
https://issues.apache.org/jira/browse/TINKERPOP-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755006#comment-17755006
]
ASF GitHub Bot commented on TINKERPOP-2982:
-------------------------------------------
spmallette commented on code in PR #2206:
URL: https://github.com/apache/tinkerpop/pull/2206#discussion_r1295708860
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinResponseDecoder.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.driver.handler;
+
+import io.netty.channel.ChannelHandler;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.MessageToMessageDecoder;
+import io.netty.handler.codec.http.FullHttpResponse;
+import io.netty.handler.codec.http.websocketx.BinaryWebSocketFrame;
+import io.netty.handler.codec.http.websocketx.TextWebSocketFrame;
+import io.netty.handler.codec.http.websocketx.WebSocketFrame;
+import io.netty.util.CharsetUtil;
+import org.apache.tinkerpop.gremlin.driver.MessageSerializer;
+import org.apache.tinkerpop.gremlin.driver.message.ResponseMessage;
+import org.apache.tinkerpop.gremlin.driver.ser.MessageTextSerializer;
+
+import java.util.List;
+
+/**
+ * Converts {@code HttpResponse} to a {@link ResponseMessage}.
+ */
+@ChannelHandler.Sharable
+public final class HttpGremlinResponseDecoder extends
MessageToMessageDecoder<FullHttpResponse> {
+ private final MessageSerializer<?> serializer;
+
+ public HttpGremlinResponseDecoder(final MessageSerializer<?> serializer) {
+ this.serializer = serializer;
+ }
+
+ @Override
+ protected void decode(final ChannelHandlerContext channelHandlerContext,
final FullHttpResponse httpResponse, final List<Object> objects) throws
Exception {
+ final String content =
httpResponse.content().toString(CharsetUtil.UTF_8);
+ objects.add(((MessageTextSerializer)
serializer).deserializeResponse(content));
Review Comment:
well, at this point, all serializers are text based so the distinction no
longer exists except in theory. we probably should collapse the interface
structure:
https://issues.apache.org/jira/browse/TINKERPOP-2985
I can add some more defensive code here in the meantime though
> Allow gremlin-driver usage over HTTP
> ------------------------------------
>
> Key: TINKERPOP-2982
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2982
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.6.5
> Reporter: Stephen Mallette
> Priority: Major
>
> Allow gremlin-driver to work over HTTP in addition to websockets.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
