[ https://issues.apache.org/jira/browse/TINKERPOP-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755007#comment-17755007 ]
ASF GitHub Bot commented on TINKERPOP-2982: ------------------------------------------- spmallette commented on code in PR #2206: URL: https://github.com/apache/tinkerpop/pull/2206#discussion_r1295709598 ########## gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpGremlinEndpointHandler.java: ########## @@ -147,40 +136,43 @@ public void channelRead(final ChannelHandlerContext ctx, final Object msg) { return; } - final Quartet<String, Map<String, Object>, String, Map<String, String>> requestArguments; + final RequestMessage requestMessage; try { - requestArguments = HttpHandlerUtil.getRequestArguments(req); + requestMessage = HttpHandlerUtil.getRequestMessageFromHttpRequest(req); } catch (IllegalArgumentException iae) { HttpHandlerUtil.sendError(ctx, BAD_REQUEST, iae.getMessage(), keepAlive); ReferenceCountUtil.release(msg); return; } - final String acceptString = Optional.ofNullable(req.headers().get("Accept")).orElse("application/json"); - final Pair<String, MessageTextSerializer<?>> serializer = chooseSerializer(acceptString); + final String acceptMime = Optional.ofNullable(req.headers().get(HttpHeaderNames.ACCEPT)).orElse("application/json"); + final Pair<String, MessageTextSerializer<?>> serializer = chooseSerializer(acceptMime); Review Comment: yes, i think my previous comment addresses that. `MessageTextSerializer` really isn't a necessary anymore. > Allow gremlin-driver usage over HTTP > ------------------------------------ > > Key: TINKERPOP-2982 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2982 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server > Affects Versions: 3.6.5 > Reporter: Stephen Mallette > Priority: Major > > Allow gremlin-driver to work over HTTP in addition to websockets. -- This message was sent by Atlassian Jira (v8.20.10#820010)