[
https://issues.apache.org/jira/browse/TINKERPOP-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118116#comment-18118116
]
ASF GitHub Bot commented on TINKERPOP-3248:
-------------------------------------------
GumpacG commented on code in PR #3673:
URL: https://github.com/apache/tinkerpop/pull/3673#discussion_r4075168321
##########
gremlin-go/driver/traversal.go:
##########
@@ -905,3 +905,6 @@ func ParseBigInt(strValue string) *big.Int {
type ByteBuffer struct {
Data []byte
}
+
+// Rune represents the GraphBinary/Gremlin Character type.
+type Rune rune
Review Comment:
I think we should consider naming this `type Char rune`. This way users
would call `g.Inject(gremlingo.Char('a'))` instead of
`g.Inject(gremlingo.Rune('a'))`. The package already names this Gremlin type
GType.Char and the internals here are already char-based (charType, charWriter,
readChar), so Char would keep the naming consistent.
> Character support in gremlin-go
> -------------------------------
>
> Key: TINKERPOP-3248
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3248
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Affects Versions: 3.8.1
> Reporter: Ken Hu
> Priority: Major
>
> gremlin-go doesn't support the Character right now but it should be
> representable with Rune. Add this to both GremlinLang and GraphBinary in
> gremlin-go.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
