[ 
https://issues.apache.org/jira/browse/TINKERPOP-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118172#comment-18118172
 ] 

ASF GitHub Bot commented on TINKERPOP-3248:
-------------------------------------------

GumpacG commented on code in PR #3673:
URL: https://github.com/apache/tinkerpop/pull/3673#discussion_r4077484365


##########
CHANGELOG.asciidoc:
##########
@@ -25,6 +25,7 @@ 
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 [[release-4-0-0]]
 === TinkerPop 4.0.0 (Release Date: NOT OFFICIALLY RELEASED YET)
 
+* Added a `Char` type to `gremlin-go` to represent the Gremlin `Character` 
type in `GremlinLang` text generation and GraphBinary serialization, since Go's 
`rune` is only an alias for `int32` and cannot be distinguished from it. The 
`GoTranslateVisitor` now translates `Character` literals instead of raising an 
error, and the `@DataChar` feature scenarios are enabled for `gremlin-go`.

Review Comment:
   This is too detailed. The entry can just be
   
   ```suggestion
   * Added a `Char` type to `gremlin-go` to represent the Gremlin `Character` 
type in `GremlinLang`.
   ```





> Character support in gremlin-go
> -------------------------------
>
>                 Key: TINKERPOP-3248
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3248
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: go
>    Affects Versions: 3.8.1
>            Reporter: Ken Hu
>            Priority: Major
>
> gremlin-go doesn't support the Character right now but it should be 
> representable with Rune. Add this to both GremlinLang and GraphBinary in 
> gremlin-go.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to