[
https://issues.apache.org/jira/browse/TINKERPOP-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18144091#comment-18144091
]
ASF GitHub Bot commented on TINKERPOP-3295:
-------------------------------------------
Cole-Greer commented on PR #3802:
URL: https://github.com/apache/tinkerpop/pull/3802#issuecomment-6840000336
Thanks for submitting the fix for this bug. Other than the 2 minor comments
above, it looks good to me.
VOTE +1 pending the extra test cases.
Regarding the child traversal cases referenced in the PR description, I
would argue that those are questions about how TraversalParents should handle
bulking, and unrelated to the bulked traverser Writing step fixes included
here. I'd be tempted to argue that the disregard for bulk in something like
`flatMap()` is actually intentional and shouldn't be changed in these cases.
That specific behaviour in response to bulked traversers is one of the few
remaining differentiators between `flatMap()` and `local()`, especially in 3.8
and beyond. I can see how that could be a contentious perspective and may
warrant further debate. Regardless, I would claim that the scope of this PR is
right for this JIRA, and if someone wishes to take issue with the bulked
traverser handling in parent steps, that warrants its own discussion.
> inject() and addV() has bulking issues
> --------------------------------------
>
> Key: TINKERPOP-3295
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3295
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.7.7
> Reporter: Stephen Mallette
> Priority: Critical
>
> {code}
> gremlin> g.inject(1,1).addV('X').id()
> ==>0
> ==>0
> gremlin> g.V().count()
> ==>1
> {code}
> the example is for {{addV()}} and the {{inject()}} start step but
> investigation should probably cover other variations of mutations like,
> {{addE()}}, {{mergeV/E()}} and {{drop()}} and steps and mid-traversal
> {{inject()}}.
> Should also cover cases like: {{g.inject(1, 1).addV('X').property(T.id,
> 'same')}}
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
