[ https://issues.apache.org/jira/browse/TINKERPOP3-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933929#comment-14933929 ]
stephen mallette commented on TINKERPOP3-850: --------------------------------------------- This one looks ok to do from my perspective. I'm cool with the fix going to the {{tp30}} branch for 3.0.2 assuming it is a completely non-breaking change for users. Getting scala folks sorted out seems like something we should do sooner than later. [~mhfrantz] do you have time to handle this one (considering the timeline we were aiming at for release of 3.0.2 that I posted earlier today)? I assume we'd need a few of gremlin structure tests added to {{GraphTest}}. If this one's good for you, i'll assign this one to you....sound good? > Reduce Graph.addVertex overload ambiguity > ----------------------------------------- > > Key: TINKERPOP3-850 > URL: https://issues.apache.org/jira/browse/TINKERPOP3-850 > Project: TinkerPop 3 > Issue Type: Improvement > Components: process > Affects Versions: 3.0.1-incubating > Reporter: Matt Frantz > Assignee: stephen mallette > Fix For: 3.1.0-incubating, 3.0.2-incubating > > > Create the following overloads: > {noformat} > Vertex addVertex(); > Vertex addVertex(String label); > Vertex addVertex(Object key, Object value, Object...keyValues); > {noformat} > This would avoid the 1-arg overload, since there is only one 1-arg variant. > It also makes the key/value structure more obvious. > BTW, the JavaDoc now says "...the odd numbered arguments are String property > keys," so if we actually allow other types, that doc should be fixed. > Motivated by this dicussion: > https://groups.google.com/d/msgid/gremlin-users/eb2a451a-af66-48a1-989c-8021473647fc%40googlegroups.com -- This message was sent by Atlassian JIRA (v6.3.4#6332)