[
https://issues.apache.org/jira/browse/TINKERPOP3-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942474#comment-14942474
]
Matt Frantz commented on TINKERPOP3-850:
----------------------------------------
There are many places where {{Graph.addVertex}} is called with an array
({{Object[]}}) of key/value pairs. The proposed change breaks those use cases.
My question is whether the following set of overloads (with the final one
being new to the proposal) would confuse Scala:
{noformat}
Vertex addVertex();
Vertex addVertex(String label);
Vertex addVertex(Object key, Object value, Object...keyValues);
Vertex addVertex(Object[] keyValues);
{noformat}
> Reduce Graph.addVertex overload ambiguity
> -----------------------------------------
>
> Key: TINKERPOP3-850
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-850
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.1-incubating
> Reporter: Matt Frantz
> Assignee: Matt Frantz
> Fix For: 3.1.0-incubating, 3.0.2-incubating
>
>
> Create the following overloads:
> {noformat}
> Vertex addVertex();
> Vertex addVertex(String label);
> Vertex addVertex(Object key, Object value, Object...keyValues);
> {noformat}
> This would avoid the 1-arg overload, since there is only one 1-arg variant.
> It also makes the key/value structure more obvious.
> BTW, the JavaDoc now says "...the odd numbered arguments are String property
> keys," so if we actually allow other types, that doc should be fixed.
> Motivated by this dicussion:
> https://groups.google.com/d/msgid/gremlin-users/eb2a451a-af66-48a1-989c-8021473647fc%40googlegroups.com
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
