Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/commit/e5ce020727e83bdde04d21b8245902bbef8e98b0#commitcomment-13856657
@pluradj I didn't get to review this body of code carefully as it came
after my vote, so i'll tack in a word or two here. First, the test order
should be:
1. should0_InstallAndUninstallDependencies
1. should1_ThrowIllegalStateException
1. should2_ThrowRuntimeException
Is that right? Doesn't seem to always run that way in intellij for me and
leads to test failures. I also don't think we forced tests to run that way in
maven (but maybe we do)....so these tests might be getting lucky in passing. I
think it would be better to make the tests run independent of order.
Also, is there a reason you use `gremlin-groovy`? can you switch to
something more lightweight that doesn't carry a lot of transitive dependencies,
like `commons-io` or the like? I guess `gremlin-groovy` is cool, but i've seen
some environments that struggle with the jackson dependency sometimes and it
might cause odd test failures in those cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
