Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/114#issuecomment-149631015
Now that I look at this more closely, I feel like there was a reason for
that being there (as the code was the way you had it before hand). I think I
wrote a test that validates that, so on top of `mvn clean install` you should
also be sure that the integration tests for gremlin-server succeed:
```text
mvn clean install
cd gremlin-server
mvn verify -DskipIntegrationTests=false
```
With respect to Marko's question about adding a test case, you might be
able to write a unit test here:
https://github.com/apache/incubator-tinkerpop/blob/b8dbfc34f523f60be4c341699414fb5e28e8e6aa/gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ser/GryoMessageSerializerV1d0Test.java
If you can only re-create it top-down from the Gremlin Server side, then
let me know and I can get you oriented on where/how to do that.
Finally, relating to the code change itself, shouldn't the same changes be
made in "request" serialization here (where code is quite similar):
https://github.com/englishtown/incubator-tinkerpop/blob/serializer-returns-empty-buffer-fix/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ser/GryoMessageSerializerV1d0.java#L293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
