Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/114#issuecomment-149858993
  
    Created an issue in JIRA to tie this to:
    
    https://issues.apache.org/jira/browse/TINKERPOP3-903
    
    @okram note that i think @christianbellinaef only ran Gremlin Server 
integration tests.  I wouldn't anticipate problems though with spark as the 
code that was changed is related to serializing Gremlin Server request/response 
messages which I don't think have much to do with spark.
    
    One of these days I'm going to know when to flush and when not to :toilet: 
    
    In the future, please watch your IDE settings - as a point of code style 
TinkerPop code doesn't use wildcarded imports:
    
    
https://github.com/apache/incubator-tinkerpop/pull/114/files#diff-c68ab1009a5e6ce5daaf5f10349a34eeR52
    
    I'll fix that up on the merge and update CHANGELOG.
    
    I ran `mvn clean install` and integration tests for Gremlin Server and they 
seem to work ok.
    
    VOTE: +1 (binding)
    
    @pluradj do you have some time to give us the final vote we need to get 
this merged?
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to