[
https://issues.apache.org/jira/browse/TINKERPOP3-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023400#comment-15023400
]
ASF GitHub Bot commented on TINKERPOP3-984:
-------------------------------------------
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/150#issuecomment-159107744
Tests pass and code looks good. However, I wonder why you've used
`graphProvider.convertId(1, Vertex.class)` instead of
`convertToVertexId("marko")`. But I guess I'm missing something here, since
@okram mentioned that he reviewed the code and he's fine with it. Hence:
VOTE: +1
> Use GraphProvider for id conversion in Groovy Environment test suite
> --------------------------------------------------------------------
>
> Key: TINKERPOP3-984
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-984
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Reporter: Marvin Froeder
> Assignee: Marko A. Rodriguez
> Fix For: 3.1.1-incubating
>
>
> Groovy related tests rely on ID.toString(), which can cause problems with any
> implementation that uses non-primitive ids:
> {code}
> Script1.groovy: 1: unexpected char: '#' @ line 1, column 5.
> g.V(#11:0).next()
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
