[ 
https://issues.apache.org/jira/browse/TINKERPOP3-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023439#comment-15023439
 ] 

ASF GitHub Bot commented on TINKERPOP3-984:
-------------------------------------------

Github user dkuppitz commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/150#issuecomment-159110866
  
    I saw that, but I still think that `convertToVertexId("marko")` is the 
cleaner (cleanest?) way to do it, especially if the test uses the modern graph.


> Use GraphProvider for id conversion in Groovy Environment test suite
> --------------------------------------------------------------------
>
>                 Key: TINKERPOP3-984
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-984
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.0.2-incubating
>            Reporter: Marvin Froeder
>            Assignee: Marko A. Rodriguez
>             Fix For: 3.1.1-incubating
>
>
> Groovy related tests rely on ID.toString(), which can cause problems with any 
> implementation that uses non-primitive ids:
> {code}
> Script1.groovy: 1: unexpected char: '#' @ line 1, column 5.
>    g.V(#11:0).next()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to