[
https://issues.apache.org/jira/browse/TINKERPOP3-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023446#comment-15023446
]
ASF GitHub Bot commented on TINKERPOP3-886:
-------------------------------------------
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/141#issuecomment-159111306
@kushal256 i've merged this one. thanks for working through all that.
note that were some weird file permission changes that came with your PR. I
reverted those:
https://github.com/apache/incubator-tinkerpop/commit/5f1a354e577b7c31f00469c91acae61a6144a85f
for some reason, all those files were made executable. ??? anyway,
something to watch for your next PR. thanks again!
> Allow any GraphReader/Writer to be persistence engine for TinkerGraph
> ----------------------------------------------------------------------
>
> Key: TINKERPOP3-886
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-886
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: tinkergraph
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Trivial
> Fix For: 3.1.1-incubating
>
>
> TinkerGraph currently works with gryo, graphml and graphson - all internal
> formats to TinkerPop. This could easily be extended to work with any format
> implementing the appropriate interfaces (i.e. also external third-party
> formats) by allowing for the `gremlin.tinkergraph.graphFormat` setting for
> TinkerGraph to be set to the existing three settings, but also allow for it
> to be the fully qualified class name for a {{Io.Builder<I extends Io>}}
> interface. TinkerGraph could then dynamically instantiate this class (which
> we can expect to have a zero-arg constructor) and use it to load/save data.
> This might actually also clean up some of the existing code around load/save.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
