[
https://issues.apache.org/jira/browse/TINKERPOP3-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014090#comment-15014090
]
ASF GitHub Bot commented on TINKERPOP3-886:
-------------------------------------------
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/141#issuecomment-158146890
Looks good to me. Ran the tests and then played around with it in the
shell a bit. Exception message is good on a bogus persistence engine and gryo
and graphson work as expected.
+1
> Allow any GraphReader/Writer to be persistence engine for TinkerGraph
> ----------------------------------------------------------------------
>
> Key: TINKERPOP3-886
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-886
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: tinkergraph
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Trivial
>
> TinkerGraph currently works with gryo, graphml and graphson - all internal
> formats to TinkerPop. This could easily be extended to work with any format
> implementing the appropriate interfaces (i.e. also external third-party
> formats) by allowing for the `gremlin.tinkergraph.graphFormat` setting for
> TinkerGraph to be set to the existing three settings, but also allow for it
> to be the fully qualified class name for a {{Io.Builder<I extends Io>}}
> interface. TinkerGraph could then dynamically instantiate this class (which
> we can expect to have a zero-arg constructor) and use it to load/save data.
> This might actually also clean up some of the existing code around load/save.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
