[
https://issues.apache.org/jira/browse/TINKERPOP-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052094#comment-15052094
]
ASF GitHub Bot commented on TINKERPOP-1019:
-------------------------------------------
GitHub user n-tran opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/177
TINKERPOP-1019 Replaced all system.out.println and system.out.error with
logger.
Removed the `muteTestLog` system property because logging can now be
controlled by config file.
Ran `mvn clean install` and `mvn clean install -Dci`
Logging appear appropriate in both cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/n-tran/incubator-tinkerpop TINKERPOP-1019
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #177
----
commit 0c783835c165b3c9097418947db252cc399a5c52
Author: Nghia Tran <[email protected]>
Date: 2015-12-11T03:24:02Z
Replaced all system.out.println and system.out.error with logger.
Removed the muteTestLog system property because logging can now be
controlled by config file.
----
> Convert println in test to SLF4j
> --------------------------------
>
> Key: TINKERPOP-1019
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1019
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.1.0-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> Not sure why we used printlns for debugging. We should just switch to slf4j
> and then control the output with the log4j.properties file. We could then
> drop the special usage of the {{muteTestLogs}} system property.
> Part of this should be to sort out what's going on with controlling
> {{log4.properties}} from maven. That creates problems apparently (attempted
> to do that on a different ticket and caused hadoop/spark stuff to fail)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
