[
https://issues.apache.org/jira/browse/TINKERPOP-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056228#comment-15056228
]
ASF GitHub Bot commented on TINKERPOP-1019:
-------------------------------------------
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/177#discussion_r47519037
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
---
@@ -71,7 +73,7 @@
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
public class GremlinDriverIntegrateTest extends
AbstractGremlinServerIntegrationTest {
-
+ private static final Logger logger =
LoggerFactory.getLogger(AbstractGremlinServerIntegrationTest.class);
--- End diff --
This should be `LoggerFactory.getLogger(GremlinDriverIntegrateTest
.class)`, right?
> Convert println in test to SLF4j
> --------------------------------
>
> Key: TINKERPOP-1019
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1019
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.1.0-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> Not sure why we used printlns for debugging. We should just switch to slf4j
> and then control the output with the log4j.properties file. We could then
> drop the special usage of the {{muteTestLogs}} system property.
> Part of this should be to sort out what's going on with controlling
> {{log4.properties}} from maven. That creates problems apparently (attempted
> to do that on a different ticket and caused hadoop/spark stuff to fail)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
