[ 
https://issues.apache.org/jira/browse/TINKERPOP-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067948#comment-15067948
 ] 

ASF GitHub Bot commented on TINKERPOP-983:
------------------------------------------

Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/184#issuecomment-166580595
  
    Not sure why travis didn't pick this up for build, but I pulled the changes 
and it failed for me too. It's a subtle problem, but the fix is to add this 
method to your `ManagedGraphProvider`:
    
    ```java
    @Override
    public String getWorkingDirectory() {
        return innerGraphProvider.getWorkingDirectory();
    }
    ```
    
    Without that, HDFS gets the wrong directory and the assert fails. Please 
try that and see if it fixes your problem with the build.  If all good, please 
update your PR and we can review in full.


> Provide a way to track open Graph instances in tests
> ----------------------------------------------------
>
>                 Key: TINKERPOP-983
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-983
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>             Fix For: 3.1.1-incubating
>
>
> Tests open {{Graph}} instances and if they fail to close them all (tends to 
> happen on tests that throw exceptions and don't directly call {{close()}}), 
> it can result in problems for providers when they run the tests.  Provide a 
> method to give the test writer feedback on {{Graph}} instances that aren't 
> closed so that they know at test writing time of the problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to