[
https://issues.apache.org/jira/browse/TINKERPOP-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073836#comment-15073836
]
ASF GitHub Bot commented on TINKERPOP-983:
------------------------------------------
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/184#issuecomment-167773779
All good with:
```text
mvn clean install -DincludeNeo4j && mvn verify -DskipIntegrationTests=false
-DincludeNeo4j
```
The approach makes sense to me. Not sure how else it could be done short
of placing the burden on providers to ensure that open `Graph` implementations
were tracked.
VOTE +1
> Provide a way to track open Graph instances in tests
> ----------------------------------------------------
>
> Key: TINKERPOP-983
> URL: https://issues.apache.org/jira/browse/TINKERPOP-983
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> Tests open {{Graph}} instances and if they fail to close them all (tends to
> happen on tests that throw exceptions and don't directly call {{close()}}),
> it can result in problems for providers when they run the tests. Provide a
> method to give the test writer feedback on {{Graph}} instances that aren't
> closed so that they know at test writing time of the problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
