Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/211#issuecomment-180402242
Glad you figured out how to get that pull request done - cool! A few things:
1. Travis is failing, but i dont think that's your fault - from the looks
of the output it seems that Travis just died mid build somehow. I can test the
build of your PR manually when the time comes.
1. could you quickly edit the name of your PR to be prefixed with the JIRA
issue? That will allow our comments to hook into JIRA nicely for all comments
on this ticket. In other words, just change the title to "TINKERPOP-1125 Use
the existing Host iterator"
1. Did you run the Gremlin Server integration tests? Basically, after `mvn
clean install` you can just do: `mvn verify -DskipIntegrationTests=false -pl
gremlin-server`. Those don't get executed by Travis.
Sorry for the extra "administrative" work and I can't imagine you've broken
anything with this change, but I just would like you to know what our pull
request procedure looks like. You can read more about such things here in the
contributor docs:
http://tinkerpop.apache.org/docs/3.1.0-incubating/developer.html#_pull_request_format
Last but not least, the tp31 branch is currently frozen for release of
3.1.1-incubating which will go up for vote on Monday, so we probably won't look
to merge this in until that is all settled. Thanks again - please keep the PRs
coming. :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
