Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/211#issuecomment-181950663
  
    I did some review of this.  it would be nice if you could add a test to 
cover TINKERPOP-1127.  Should be easy enough to do:
    
    First, edit AbstractGremlinServerIntegrationTest to include a 
`startServer()` method:
    
    ```java
    public void startServer() throws Exception {
        server.start().join();
    }
    ````
    
    Next, modify the existing test in 
`GremlinServerIntegrateTest.shouldFailOnDeadHost()` to call that method to 
restart the server toward the end of the test and include an assert to validate 
that a request can be made.  
    
    Does that make sense?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to