[ 
https://issues.apache.org/jira/browse/TINKERPOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163726#comment-15163726
 ] 

ASF GitHub Bot commented on TINKERPOP-958:
------------------------------------------

GitHub user rjbriody opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/242

    TINKERPOP-958: split .profile() into ProfileSideEffectStep and ProfileStep 
(which is a MapStep).

    https://issues.apache.org/jira/browse/TINKERPOP-958
    
    I split .profile() into ProfileSideEffectStep and ProfileStep (which is a 
MapStep).
    
    ```.profile()``` emits a TraversalMetrics.
    ```profile('side effect key')``` stores TraversalMetrics in a side effect.
    
    Tests modified and added.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rjbriody/incubator-tinkerpop TINKERPOP-958

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #242
    
----
commit 8e807eec73a72b4bbbde3156e6aa8b237d099b42
Author: rjbriody <bob.bri...@datastax.com>
Date:   2016-02-24T20:08:25Z

    TINKERPOP-958 split .profile() into ProfileSideEffectStep and ProfileStep 
(which is a MapStep).

----


> Improve usability of .profile() step.
> -------------------------------------
>
>                 Key: TINKERPOP-958
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-958
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>            Reporter: Bob Briody
>            Assignee: Marko A. Rodriguez
>             Fix For: 3.2.0-incubating
>
>
> The .profile() step is currently tedious to use. One must remember this 
> entire string to activate profiling and cap off the result: 
> "profile().cap(TraversalMetrics.METRICS_KEY)".
> This should be streamlined.
> -Additionally, if the TraversalMetrics are cap'd off the end of the traversal 
> then this step and the duration it takes should be excluded from the metrics 
> and timers.- (Moved to own ticket: 
> https://issues.apache.org/jira/browse/TINKERPOP-1078)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to