[
https://issues.apache.org/jira/browse/TINKERPOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167221#comment-15167221
]
ASF GitHub Bot commented on TINKERPOP-958:
------------------------------------------
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/242#issuecomment-188795098
A few things.
1. The name of the test is `ProfileTest.Traversals` not
`ProfileSideEffectTest.Traversals`. Its based on the `GraphTraversal.name()`,
not the underlying step. Likewise for `GroovyProfileTest.Traversals`. Thus, put
all those tests into one test suite. See how there is no
`GroupCountSideEffectTest.Traversals`, just `GroupCountTest.Traversals`.
2. Can you provide (as a comment here) the following -- UPGRADE
instructions for users and CHANGELOG notes. Don't do it in the code as merging
might suck. If you put it here, I can put it in on merge.
3. Can you verify that Giraph/Spark are happy?
Thanks @rjbriody
> Improve usability of .profile() step.
> -------------------------------------
>
> Key: TINKERPOP-958
> URL: https://issues.apache.org/jira/browse/TINKERPOP-958
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Reporter: Bob Briody
> Assignee: Marko A. Rodriguez
> Fix For: 3.2.0-incubating
>
>
> The .profile() step is currently tedious to use. One must remember this
> entire string to activate profiling and cap off the result:
> "profile().cap(TraversalMetrics.METRICS_KEY)".
> This should be streamlined.
> -Additionally, if the TraversalMetrics are cap'd off the end of the traversal
> then this step and the duration it takes should be excluded from the metrics
> and timers.- (Moved to own ticket:
> https://issues.apache.org/jira/browse/TINKERPOP-1078)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
