[ https://issues.apache.org/jira/browse/TINKERPOP-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211773#comment-15211773 ]
ASF GitHub Bot commented on TINKERPOP-1016: ------------------------------------------- Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/274#issuecomment-201267112 So benchmarks complete and then i get this file added: ```text $ git status On branch TINKERPOP-1016 Your branch is up-to-date with 'origin/TINKERPOP-1016'. Untracked files: (use "git add <file>..." to include in what will be committed) gremlin-benchmark/dependency-reduced-pom.xml ``` I think it came as a result of the benchmark run (i certainly didn't add it myself). Should that be in .gitignore? > Replace junit-benchmarks with JMH > --------------------------------- > > Key: TINKERPOP-1016 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1016 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite > Affects Versions: 3.1.0-incubating > Reporter: Ted Wilmes > Assignee: Ted Wilmes > Priority: Minor > > Replace junit-benchmark with JMH. This includes the following tasks: > * Evaluate which existing benchmarks should be kept and port them to JMH. > * Add an initial JMH benchmark for TINKERPOP-957 > * See if we can trigger perf tests with the same scheme that is currently > used {noformat}mvn verify -DskipPerformanceTests=true/false{noformat} > * Write developer docs that outline our initial performance testing approach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)