[ 
https://issues.apache.org/jira/browse/TINKERPOP-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211767#comment-15211767
 ] 

ASF GitHub Bot commented on TINKERPOP-1016:
-------------------------------------------

Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/274#issuecomment-201265647
  
    I took an error while running the benchmarks:
    
    ```text
    # JMH 1.11.3 (released 71 days ago)
    # VM version: JDK 1.8.0_72, VM 25.72-b15
    # VM invoker: /usr/lib/jvm/java-8-oracle/jre/bin/java
    # VM options: -server -Xms512m -Xmx512m
    # Warmup: 10 iterations, 1 s each
    # Measurement: 10 iterations, 1 s each
    # Timeout: 10 min per iteration
    # Threads: 1 thread, will synchronize iterations
    # Benchmark mode: Throughput, ops/time
    # Benchmark: 
org.apache.tinkerpop.gremlin.process.GraphTraversalBenchmark.g_V_out_out_out_path
    
    # Run progress: 72.73% complete, ETA 00:03:01
    # Fork: 1 of 2
    # Warmup Iteration   1: <failure>
    
    java.lang.OutOfMemoryError: GC overhead limit exceeded
        at java.util.LinkedHashMap$LinkedKeySet.iterator(LinkedHashMap.java:539)
        at java.util.HashSet.iterator(HashSet.java:172)
        at 
java.util.Collections$UnmodifiableCollection$1.<init>(Collections.java:1039)
        at 
java.util.Collections$UnmodifiableCollection.iterator(Collections.java:1038)
        at java.util.AbstractCollection.addAll(AbstractCollection.java:343)
        at 
org.apache.tinkerpop.gremlin.process.traversal.step.util.ImmutablePath.<init>(ImmutablePath.java:58)
        at 
org.apache.tinkerpop.gremlin.process.traversal.step.util.ImmutablePath.extend(ImmutablePath.java:68)
        at 
org.apache.tinkerpop.gremlin.process.traversal.traverser.B_LP_O_P_S_SE_SL_Traverser.split(B_LP_O_P_S_SE_SL_Traverser.java:65)
        at 
org.apache.tinkerpop.gremlin.process.traversal.step.map.FlatMapStep.processNextStart(FlatMapStep.java:44)
        at 
org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.hasNext(AbstractStep.java:140)
        at 
org.apache.tinkerpop.gremlin.process.traversal.step.util.ExpandableStepIterator.next(ExpandableStepIterator.java:50)
        at 
org.apache.tinkerpop.gremlin.process.traversal.step.map.MapStep.processNextStart(MapStep.java:36)
        at 
org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.next(AbstractStep.java:126)
        at 
org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.next(AbstractStep.java:37)
        at 
org.apache.tinkerpop.gremlin.process.traversal.Traversal.fill(Traversal.java:146)
        at 
org.apache.tinkerpop.gremlin.process.traversal.Traversal.toList(Traversal.java:103)
        at 
org.apache.tinkerpop.gremlin.process.GraphTraversalBenchmark.g_V_out_out_out_path(GraphTraversalBenchmark.java:56)
        at 
org.apache.tinkerpop.gremlin.process.generated.GraphTraversalBenchmark_g_V_out_out_out_path_jmhTest.g_V_out_out_out_path_thrpt_jmhStub(GraphTraversalBenchmark_g_V_out_out_out_path_jmhTest.java:104)
        at 
org.apache.tinkerpop.gremlin.process.generated.GraphTraversalBenchmark_g_V_out_out_out_path_jmhTest.g_V_out_out_out_path_Throughput(GraphTraversalBenchmark_g_V_out_out_out_path_jmhTest.java:69)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:430)
        at 
org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:412)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
    ```
    
    is that expected in some way (it seemed to keep running)?


> Replace junit-benchmarks with JMH
> ---------------------------------
>
>                 Key: TINKERPOP-1016
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1016
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.1.0-incubating
>            Reporter: Ted Wilmes
>            Assignee: Ted Wilmes
>            Priority: Minor
>
> Replace junit-benchmark with JMH.  This includes the following tasks:
> * Evaluate which existing benchmarks should be kept and port them to JMH.
> * Add an initial JMH benchmark for TINKERPOP-957
> * See if we can trigger perf tests with the same scheme that is currently 
> used {noformat}mvn verify -DskipPerformanceTests=true/false{noformat}
> * Write developer docs that outline our initial performance testing approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to