[ 
https://issues.apache.org/jira/browse/TINKERPOP-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248340#comment-15248340
 ] 

ASF GitHub Bot commented on TINKERPOP-1269:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/292

    TINKERPOP-1269 Additional SSL options for Driver

    This is a really boring PR - just added some more flexibility to the driver 
to allow the user to do more SSL stuff. Existing SSL settings still works as 
before:
    
    ```text
    gremlin> :remote connect tinkerpop.server conf/remote-secure.yaml
    WARN  org.apache.tinkerpop.gremlin.driver.Channelizer$AbstractChannelizer  
- SSL configured without a trustCertChainFile and thus trusts all certificates 
without verification (not suitable for production)
    ==>Connected - localhost/127.0.0.1:8182
    gremlin> :remote console
    ==>All scripts will now be sent to Gremlin Server - 
[localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
    gremlin> 1 + 1
    ==>2
    ```
    
    Tests for SSL still working after:
    
    ```text
    $ mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false -DincludeNeo4j
    ``` 
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1269

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #292
    
----
commit f779cf9227c93fa5a2e4c3716ff460e1ed8f97a4
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-19T17:53:35Z

    Added additional SSL configuration options for Gremlin Driver.
    
    Specifically added: keyPassword, keyFile and keyCertChainFile.

commit 38b474a7c7ef1e4dd7a86767daa4c7644fec707d
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-19T18:02:12Z

    Added docs for new SSL settings on the driver side.

----


> More SSL settings for driver
> ----------------------------
>
>                 Key: TINKERPOP-1269
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1269
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver
>    Affects Versions: 3.1.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.1.3
>
>
> We're missing a few SSL settings for Gremlin Driver - specifically (i 
> believe) the settings that allow SSL authentication. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to