[
https://issues.apache.org/jira/browse/TINKERPOP-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250630#comment-15250630
]
ASF GitHub Bot commented on TINKERPOP-1269:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/293
TINKERPOP-1269 More Configuration Options for SSL
Pretty boring pull request. Added more SSL configuration options for
Gremlin Driver and Server. Existing SSL tests still work and I added a new one
to validate the overrides worked. Everything still good with:
```text
$ mvn clean install -DskipTests && mvn verify -pl gremlin-server
-DskipIntegrationTests=false
```
Did some manual testing as well with with the `gremlin-server-secure.yaml`
and the console:
```text
gremlin> :remote connect tinkerpop.server conf/remote-secure.yaml
==>Connected - localhost/127.0.0.1:8182
gremlin> :remote console
==>All scripts will now be sent to Gremlin Server -
[localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
gremlin> 1+1
==>2
```
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1269
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit 57416163be0470d0dcd124bebc12efe325578805
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-04-19T17:53:35Z
Added additional SSL configuration options for Gremlin Driver.
Specifically added: keyPassword, keyFile and keyCertChainFile.
commit cfa95c8a29b4e27c9fd8e047a5e3631f915de005
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-04-19T18:02:12Z
Added docs for new SSL settings on the driver side.
commit 9996066189686812befdeb69e33ef2e9a8a6b9b7
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-04-20T17:50:01Z
Added ability to pass an SslContext to the driver.
This will be useful if the user needs more complex ssl configuration than
the Cluster builder allows.
commit 75e875700201013df7b2323a7a11907c0b9ce500
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-04-20T20:13:24Z
Added configuration for overriding the Gremlin Server SSL config with
SslContext.
----
> More SSL settings for driver
> ----------------------------
>
> Key: TINKERPOP-1269
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1269
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.1.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Fix For: 3.1.3
>
>
> We're missing a few SSL settings for Gremlin Driver - specifically (i
> believe) the settings that allow SSL authentication.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
