Author: markt
Date: Sat Nov 11 13:40:43 2006
New Revision: 473802
URL: http://svn.apache.org/viewvc?view=rev&rev=473802
Log:
Fix bug 40860. Additional logging if parameter processing fails.
Modified:
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/http/Parameters.java
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml
Modified:
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/http/Parameters.java
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/http/Parameters.java?view=diff&rev=473802&r1=473801&r2=473802
==============================================================================
---
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/http/Parameters.java
(original)
+++
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/http/Parameters.java
Sat Nov 11 13:40:43 2006
@@ -382,9 +382,9 @@
pos=valEnd+1;
if( nameEnd<=nameStart ) {
+ log.warn("Parameters: Invalid chunk ignored.");
continue;
// invalid chunk - it's better to ignore
- // XXX log it ?
}
tmpName.setBytes( bytes, nameStart, nameEnd-nameStart );
tmpValue.setBytes( bytes, valStart, valEnd-valStart );
@@ -393,6 +393,8 @@
addParam( urlDecode(tmpName, enc), urlDecode(tmpValue, enc) );
} catch (IOException e) {
// Exception during character decoding: skip parameter
+ log.warn("Parameters: Character decoding failed. " +
+ "Parameter skipped.", e);
}
tmpName.recycle();
Modified:
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties?view=diff&rev=473802&r1=473801&r2=473802
==============================================================================
---
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties
(original)
+++
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties
Sat Nov 11 13:40:43 2006
@@ -46,6 +46,7 @@
coyoteRequest.listenerStart=Exception sending context initialized event to
listener instance of class {0}
coyoteRequest.listenerStop=Exception sending context destroyed event to
listener instance of class {0}
coyoteRequest.attributeEvent=Exception thrown by attributes event listener
+coyoteRequest.parseParameters=Exception thrown whilst processing POSTed
parameters
coyoteRequest.postTooLarge=Parameters were not parsed because the size of the
posted data was too big. Use the maxPostSize attribute of the connector to
resolve this if the application should accept large POSTs.
requestFacade.nullRequest=Null request object
responseFacade.nullResponse=Null response object
Modified:
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java?view=diff&rev=473802&r1=473801&r2=473802
==============================================================================
---
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java
(original)
+++
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java
Sat Nov 11 13:40:43 2006
@@ -2375,7 +2375,8 @@
parameters.processParameters(formData, 0, len);
}
} catch (Throwable t) {
- ; // Ignore
+ context.getLogger().warn
+ (sm.getString("coyoteRequest.parseParameters"), t);
}
}
Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=473802&r1=473801&r2=473802
==============================================================================
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Sat Nov 11 13:40:43 2006
@@ -112,6 +112,10 @@
(markt)
</fix>
<fix>
+ <bug>40860</bug>: Log exceptions and other problems during parameter
+ processing. (markt)
+ </fix>
+ <fix>
<bug>40901</bug>: Encode directory listing output. Based on a patch
provided by Chris Halstead. (markt)
</fix>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
