-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 All,
Thanks for volunteering to RM this release. Sigs are correct. Unit test failure is environmental in nature. +1 to release STABLE 8.5.37 - -chris On 12/16/18 11:02, Christopher Schultz wrote: > All, > > On 12/12/18 08:22, Mark Thomas wrote: >> The proposed Apache Tomcat 8.5.37 release is now available for >> voting. > >> The major changes compared to the 8.5.35 release are: > >> - Implement the requirements of section 8.2.2 2.c of the Servlet >> specification and prevent a web application from deploying if >> it has fragments with duplicate names and is configured to use >> relative ordering of fragments. > >> - The default Servlet no longer overrides a previously set >> content-type. > >> - Update the packaged version of the Tomcat Native Library to >> 1.2.19 to pick up the latest Windows binaries built with APR >> 1.6.5 and OpenSSL 1.1.1a. > >> Along with lots of other bug fixes and improvements. > >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/ >> The Maven staging repo is: >> https://repository.apache.org/content/repositories/orgapachetomcat-12 0 > >> 1/ > > > The svn tag is: >> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_37/ > >> The proposed 8.5.37 release is: [ ] Broken - do not release [ ] >> Stable - go ahead and release as 8.5.37 > > I've got a signature problem with the Windows installer (see > below). Everything else seems okay. I'll hold my +1 until we sort > that out. > > Works with a standard servlet application. > > Details: > > * Environment * Java (build): java version "1.8.0_181" > Java(TM) SE Runtime Environment (build 1.8.0_181-b13) Java > HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode) * Java > (test): java version "1.8.0_181" Java(TM) SE Runtime > Environment (build 1.8.0_181-b13) Java HotSpot(TM) 64-Bit Server > VM (build 25.181-b13, mixed mode) * OS: Linux 2.6.32-312-ec2 > x86_64 * cc: cc (Debian 4.7.2-5) 4.7.2 * make: GNU Make > 3.81 * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 * APR: 1.4.6 * > Valid SHA-2512 signature for apache-tomcat-8.5.37.zip * Valid GPG > signature for apache-tomcat-8.5.37.zip * Valid SHA-512 signature > for apache-tomcat-8.5.37.tar.gz * Valid GPG signature for > apache-tomcat-8.5.37.tar.gz * !! Invalid SHA-256 signature for > apache-tomcat-8.5.37.exe > > Hmm. The SHA512 sig I get is: > > 0d0ed883f57e85d334450a27c5104b17f4a99156eeba9ebf81ea8a0b3a56d021b990b0 0b > > 7c289163c9b3478e00d54935f0b65d6df9de04d05ba9b3f0ce2437cc > > The sig file says: > > 2ef46708f1d04561481ba23dca78a13eaf32cfe0e5c681e58353cc08f446f627da29ef 18 > > 97bbbb94df2b38e9190886300e7a8dca69c604ad4f29d9d0871fc553 > > * !! Invalid GPG signature for apache-tomcat-8.5.37.exe > > $ gpg --verbose --keyring ./apache-keys --no-default-keyring > --verify apache-tomcat-8.5.37.exe.asc apache-tomcat-8.5.37.exe gpg: > Signature made Wed 12 Dec 2018 07:08:29 AM EST using RSA key ID > 2F6059E7 gpg: using PGP trust model gpg: BAD signature from "Mark E > D Thomas <ma...@apache.org>" gpg: binary signature, digest > algorithm SHA256 > > > I got a fresh copy from > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.37/bin/ > > and I'm getting the same errors on that file. > > * Valid SHA512 signature for apache-tomcat-8.5.37-src.zip * Valid > GPG signature for apache-tomcat-8.5.37-src.zip * Valid SHA512 > signature for apache-tomcat-8.5.37-src.tar.gz * Valid GPG signature > for apache-tomcat-8.5.37-src.tar.gz * Binary Zip and tarball: Same > * Source Zip and tarball: Same * Building dependencies returned: 0 > * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: > FAILED * Tests that failed: * > org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt > > I get this error in the above test: > > 14-Dec-2018 17:06:54.042 SEVERE [main] > org.apache.catalina.tribes.transport.nio.NioReceiver.start Unable > to start cluster receiver java.net.BindException: Cannot assign > requested address at sun.nio.ch.Net.bind0(Native Method) at > sun.nio.ch.Net.bind(Net.java:433) at > sun.nio.ch.Net.bind(Net.java:425) at > sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:2 23 > > ) > at > sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) at > sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67) > at > org.apache.catalina.tribes.transport.ReceiverBase.bind(ReceiverBase.ja va > > :205) > > > I'm not sure what address is being attempted there, but this could > be an environmental issue. Historically, I've had issues with > Tribes integration tests, though I have far fewer of them these > days. I used to think it was because of lack of multicast, but it > appears that multicast is indeed enabled. > > Re-running the test again also fails. Any ideas for what to look > for? > > -chris > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwX10AACgkQHPApP6U8 pFhmsxAAxxLxIVR2kNs+nq+OoPGri50PfBA7VjNkimpFOGBaxKe86QbRfxsoyrCV opZsOzV4czuEJ75ZrtFxSvjVkzeJjcLPNyAWusNDtDIXJJR2SIWOLgpX7svSld3W zZQiIamUs1YP7FMNKyMJJM6MTuNX/EOkWXw7PWHaoUFndsr7lpjHyDdq75ALmOTF 2j82g+yZuXlu0S9ZnJqqvguW7FL0EpdUeStFjMwDzZd1SKLiqv0KntoKxgaJpmqD N42yMOup5ra7yjKmsaI545/BltZ8mjGlWQShoOhaHfKhv859myetYLwxXLmULurj IjsaOKssVd2jBsGwGW0ZyqjxolSqH+hdHw7HssBNELI2pl7xB42S/dKN536wYOnI vIWXif+SewcL7zuZ/tLycfhntwTthZTUzqgzcb6t4CyY+WC1muXCEoAr9tyy+Qq9 u9pRcQbbyayKZIpHEyxhwp1bk3vOxW8Y9uWOQfNSJKFvNNmDu1UxHxfXv2P9uRRE YvCgzsIUFq89F+qh4wvWi/NfXaV/JB0r56N9YHvYkAWDEe4W8MrAbIFYuPyLuc2y uZ5UeT4P4C+WhH9Cru7rh2Bpue/LdPbqJQQv6vITMtkgh7f4+3IbGs2+C2fEygdJ V7d3XpJHmEcao0WIvHFoFUVwiSMb+pA+M6cXpx2jbG/c8jwhuTY= =aKn4 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org