On 08/05/2019 21:58, Rémy Maucherat wrote: > On Wed, May 8, 2019 at 10:31 PM Emmanuel Bourg <ebo...@apache.org> wrote: > >> Hi all, >> >> I've rebased the javax.tools JSP compiler on top of the current master >> branch : >> >> https://github.com/ebourg/tomcat/tree/jasper-javax-tools-support >> >> Please let me know how you feel about this stuff and if it's worth merging. >> > Ok, so it feels like a win over Ant, so it should be merged, but I didn't > test it.
+1 Need to remove the @author tags and add some info on how to configure jasper to use them. A few daft questions: 1. If we used the JSR199Complier by default would that allow us to remove the Eclipse compiler as a dependency? 2. Why would anyone use the JavacCompiler in preference to JSR199Complier? Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
