On 11/10/2019 14:10, Rémy Maucherat wrote: > On Fri, Oct 11, 2019 at 1:51 PM Michael Osipov <micha...@apache.org > <mailto:micha...@apache.org>> wrote: > > Am 2019-10-11 um 11:32 schrieb Rémy Maucherat: > > On Fri, Oct 11, 2019 at 10:43 AM Mark Thomas <ma...@apache.org > <mailto:ma...@apache.org>> wrote: > > > >> On 11/10/2019 09:30, micha...@apache.org > <mailto:micha...@apache.org> wrote: > >>> This is an automated email from the ASF dual-hosted git repository. > >>> > >>> michaelo pushed a change to branch BZ-63835/8.5.x > >> > >> New features should be implemented against master and then > back-ported > >> (assuming the community accepts them). > >> > > > > I also (still) prefer either PRs (it allows comments) or in master. > > This is a first draft, nothing PR worthy. As soon as I see the code > working, I will create the PR by then and when approved in general I > will add tests and re-request review. So please be patient. > > > For this use I'd recommend using your own forked repository then. Using > a branch for that doesn't work for me, it sends way too many emails that > are not actually useful to dev to the dev mailing list. I tried for a > while, it didn't work, sorry :( > > So either: > - a PR > - directly in master
master is fine when you are fairly sure the code is right. It isn't the place for experiments since we release 9.0.x off master. > - your git fork I use the fork approach. I have a local checkout of my fork with the apache/tomcat github mirror configured as an additional remote called "upstream". Most of the time I work on upstream but occasionally, I'll push something to the fork and generate a PR to obtain feedback. I also use the fork if I need to share in-progress work between my desktop and laptop. I use upstream so much I should probably reconfigure the names of the remotes in my checkout: origin -> fork upstream -> origin Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
