On 27/11/2019 17:07, Rémy Maucherat wrote: > On Wed, Nov 27, 2019 at 5:35 PM Mark Thomas <ma...@apache.org
> My preference for writing earlier is only a slight one. I'm more > concerned that different methods take a different approach. Taking a > closer look at that is on my TODO list but it isn't a priority for me at > the moment. > > > I'll double check the inconsistency :) > > writeBlocking writes after. > writeNonBlockingInternal has that "&& > !socketBufferHandler.isWriteBufferWritable()" in the while loop that > makes the thing inconsistent, it is a leftover from the old code. > For now I'll fix that. I was looking at writeBlocking(byte[]...) and writeBlocking(ByteBuffer). I think writeBlocking(byte[]...) should use while (len > 0) for consistency shouldn't it? I think a similar inconsistency exists in the non-blocking write too. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
