Le 06/04/2020 à 17:50, Mark Thomas a écrit : >> from 5c96c0b Ignore the IntelliJ project files >> new 29ea189 Replaced NonClosing{In,Out}putStream with the equivalent >> classes from Commons IO > > -1. It adds 220k of bloat for no benefit.
No the dependencies are shaded with the minimizeJar option enabled, only the classes used are kept in the final jar. >> new 528ccfa Made the internal classes package private > > I am close to -1 on this change. > > I would rather these were left public at this stage in the development > of this tool to make it as easy as possible for folks to tinker with > this code, re-using the bits that work for them. Longer term I had the > possibility in mind that users might need to register custom Converters > so making that package private seems very out of place. > > I get that we can always relax visibility rules later but this change > looks premature to me. Ok sounds fair, I've reverted it. Emmanuel Bourg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org