On Mon, Apr 6, 2020 at 3:45 PM Emmanuel Bourg <ebo...@apache.org> wrote:
> Le 06/04/2020 à 15:38, Rémy Maucherat a écrit : > > > commit 29ea1891489060f3b3e40259098def5ae47645ef > > Author: Emmanuel Bourg <ebo...@apache.org <mailto:ebo...@apache.org > >> > > AuthorDate: Mon Apr 6 15:24:35 2020 +0200 > > > > Replaced NonClosing{In,Out}putStream with the equivalent classes > > from Commons IO > > > > > > Ah, the beauty of having Maven. Actual benefit: zero. Trouble with > > updating dependencies: one. Possible incompatibilities: one. > > So I think it's a total of -2 for the commit. > > Sorry but I'm not sure to understand your objection. Commons IO is dead > stable, these classes have been around for over 10 years and haven't > changed much since. There is really no point reimplementing them. > Reimplemeting ... It was already done, and this was a better trivial solution. This is a veto (unlike Mark I will not withdraw it), so please revert this commit. Rémy
