> 2022年8月11日 05:20，Christopher Schultz <ch...@christopherschultz.net> 写道：
>
> Han,
>
> On 8/10/22 06:25, Han Li wrote:
>> Mark,
>> Can I make a suggestion related to the ant build script. Can we add two
>> properties to set the values of ` -Duser.language` and `-Duser.country`,
>> because in the course of my testing I found that some of the unit test
>> assertions are in English, but there may be cases where the values are
>> converted by sm, e.g. Chinese.
>> Just like this:
>> Assert.assertEquals("ok”,x);
>> The variable x becomes "好" after passing through the StringManager.
>> So this makes it a bit inconvenient for non-English speaking developers to
>> test. I avoid this problem by adding a statement to build.xml each time I
>> run a test.
>> <jvmarg value="-Duser.language=en"/>
>> <jvmarg value="-Duser.country=US"/>
>> So I was wondering if we could dynamically set these two values via
>> build.properties
>
> So, two things:
>
> 1. You are proposing that we "copy" user.language and user.country from the
> ant JVM into the forked-ant JVM that runs the tests?
Yes!
>
> I'm perfectly happy to add that permanently. I see no reason not to do that.
In addition, I think that we can set user.country and user.language in
build.properties, not necessary to set them in ANT_OPTS.
>
> 2. If you set user.language and user.country in either ~/build.properties or
> ... just have them auto-set by your environment (e.g. your OS is set to use a
> particular locale) that should work. Are these values not *already* copied
> from ant JVM into forked-ant JVM for testing?
Not copied into forked-ant JVM.
Thanks,
Han
>
> -chris
>
>>> 2022年8月10日 18:02，Mark Thomas <ma...@apache.org> 写道：
>>>
>>> On 09/08/2022 20:19, Christopher Schultz wrote:
>>>> On 8/9/22 14:09, Mark Thomas wrote:
>>>
>>> <snip/>
>>>
>>>>> This issue is the zip files. Time stamps in zip files use local (yes,
>>>>> local - I didn't mistype that) time. Hence you need to use the same time
>>>>> zone to get a repeatable build.
>>>>>
>>>>> We have a few options here:
>>>>>
>>>>> 1. Document the time zone in use for the build and require the same
>>>>> timezone to be used for repeatable builds.
>>>> We might want to do this anyway, regardless.
>>>
>>> Agreed. I also spotted that adding "do.codesigning=true" would help
>>> repeatable builds. I'll get both of those added.
>>>
>>>>> 2. Require UTC.
>>>> Can that be done on the CLI for a single process on Windows? It will
>>>> likely work for *NIX no problem. I use a semi-dedicated Windows VM for
>>>> building releases, so I have no problem just switching it to UTC.
>>>
>>> I'm not sure. Figuring that out is next on my TODO list. I'd really like to
>>> make this part of the Ant build script if I can though.
>>>
>>>> I also really need to switch to building natively on my Mac because the
>>>> whole VM thing is really cramping my style. :)
>>>
>>> That should be doable. From memory, wine required a little hoop jumping to
>>> get working but it didn't take too long.
>>>
>>>>> 3. Find a way to force Ant to use a specific timezone.
>>>> -Duser.timezone?
>>>
>>> That should work. We could require that to be used on the command line. I
>>> was hoping to find a way to set that within the script so the release
>>> manager still just has to do a "ant release".
>>>
>>> I was thinking about a custom Ant task that set the global time zone (if
>>> there isn't anything built into Any that does that).
>>>
>>> Mark
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> <mailto:dev-unsubscr...@tomcat.apache.org>
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>> <mailto:dev-h...@tomcat.apache.org>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> <mailto:dev-unsubscr...@tomcat.apache.org>
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> <mailto:dev-h...@tomcat.apache.org>
