https://bz.apache.org/bugzilla/show_bug.cgi?id=66210

            Bug ID: 66210
           Summary: TestAbstractAjpProcessor&TestFlowControl tests are
                    failing on a non-English PC
           Product: Tomcat 10
           Version: unspecified
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Connectors
          Assignee: dev@tomcat.apache.org
          Reporter: aooo...@gmail.com
  Target Milestone: ------

Simliar to https://bz.apache.org/bugzilla/show_bug.cgi?id=66206

I re-ran the tests on a non-English PC and found a total of two unit tests
which are failing, because of expected value was hard-coded as en and actual
value was not. 

BUT `org.apache.coyote.http2.TestHttp2Limits#testSettingsOverheadLimits`,I
don't know know how to fix the problem of it.


Another problematic test is following one:
org.apache.coyote.http2.TestFlowControl#testNotFound

Testcase: testNotFound[0: loop [0], useAsyncIO[false]] took 0.462 sec
        FAILED
expected:<...ontent-language]-[zh[]]
3-Header-[content-...> but was:<...ontent-language]-[zh[-CN]]
3-Header-[content-...>
junit.framework.AssertionFailedError: expected:<...ontent-language]-[zh[]]
3-Header-[content-...> but was:<...ontent-language]-[zh[-CN]]
3-Header-[content-...>

The reason for this is that we should get the default local through
StringManager, not directly through Locale.getDefault(), and the toLanguageTag
method is used when setting the local of request, so we should be consistent
here as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to