https://bz.apache.org/bugzilla/show_bug.cgi?id=66210
--- Comment #4 from Han Li <aooo...@gmail.com> --- (In reply to Mark Thomas from comment #3) > Option 2 is sufficient to test the functionality primarily being tested > whereas option 3 (sort of) tests some of the i18n as well. Agreed! I also think that option 3 is the best solution. > I'm leaning towards option 3 as it doesn't look too challenging to implement > for > the small number of test cases where this is an issue. It's not too difficult to implement, and i found that the only trouble is that we may need to process the parameters in the text via regular expressions (we may not get the parameters, e.g. connectionId). So i will refix the problematic unit tests (include previous PR) according to option 3, is that OK? Han -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
