aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005142148
########## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ########## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { } @Override - public void convert(String path, InputStream src, OutputStream dest, EESpecProfile profile) throws IOException { + public boolean convert(String path, InputStream src, OutputStream dest, EESpecProfile profile) throws IOException { Manifest srcManifest = new Manifest(src); Manifest destManifest = new Manifest(srcManifest); - boolean result = false; - - result = result | removeSignatures(destManifest); + boolean result = removeSignatures(destManifest); result = result | updateValues(destManifest, profile); - if (result) { - destManifest.write(dest); - } else { - srcManifest.write(dest); Review Comment: Here it is still necessary to revert, as the conversion is fine for the specified jar, but for directory migration via the migrator, the manifest of some jars here will be affected(some jars are converted, some are not, but information for the unconverted jars is changed), even if the jar is not converted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org