aooohan commented on PR #36:

   Hi @DanielThomas ,
   > The migrator was stateless in terms of the result, so I figured that was a 
goal, which is why I went with method returns.
   On the contrary, I think that if a state is needed, that state should be 
attributed to the migrator, since `source` and `destination` values need to be 
set before executing the execute method. And for the execute method, I think it 
either succeeds or fails, and the presence or absence of converted, as you need 
it to be, is not really logically relevant to the execute method.
   > Would this method throw if execute() hasn't yet been called?
   > What should happen if execute() is called more than once for a given 
instance of the migrator?
   If the state of a given migrator with `source` and `destination` unchanged 
should remain the same as the state of the previous execution.
   BTW, for the use of migrators, I believe that a task should correspond to a 
migrator, rather than one migrator being used repeatedly to handle multiple 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

For queries about this service, please contact Infrastructure at:

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to