And in fact it doesn't matter. I found it more logical, to have JK_STATUS_ERROR and JK_STATUS_FATAL_ERROR closer together (for those reading the code). The constants are not used outside JK, so there is no compatibility problem.

It looks like your are closely following todays JK changes. I really appreciate that! Unless you find problems, I just now commited my last change (hopefully) for 1.2.25.

Regards,

Rainer

Jim Jagielski wrote:

On Aug 2, 2007, at 1:42 PM, [EMAIL PROTECTED] wrote:

==============================================================================
--- tomcat/connectors/trunk/jk/native/common/jk_ajp13.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp13.h Thu Aug 2 10:42:23 2007
@@ -45,7 +45,8 @@
 #define JK_CLIENT_RD_ERROR          (-6)
 #define JK_CLIENT_WR_ERROR          (-7)
 #define JK_STATUS_ERROR             (-8)
-#define JK_REPLY_TIMEOUT            (-9)
+#define JK_STATUS_FATAL_ERROR       (-9)
+#define JK_REPLY_TIMEOUT            (-10)


I'm curious... One reason to use C #defines is to abstract
out the macro and their values. So why, when adding
entries to we force JK_REPLY_TIMEOUT to always be
the lowest value? It shouldn't matter what the
"real" values are, right? This is especially true if we
ever want to leak these out externally :)

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to